[Bug 233654] isp(4) regression after r316398 r316399

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233654

Mark Linimon <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@FreeBSD.org |***@FreeBSD.org
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233654

--- Comment #3 from ***@playground.ru ---
Pre-316398 code only uses MSI-X for 2600+ cards.

This change in new code seems to fix the problem. May be it will be better to
add some sysctl to optionally allow MSI-X on 24xx but anyway it should be
disabled by default and might be enabled only by explicit request.


--- sys/dev/isp/ispmbox.h.orig 2018-12-18 09:49:17.549288000 +0300
+++ sys/dev/isp/ispmbox.h 2018-12-17 04:12:14.056837000 +0300
@@ -896,7 +896,7 @@
#define ISP_GET_VPIDX(isp, tag) \
(ISP_CAP_MULTI_ID(isp) ? tag : 0)
#define ISP_CAP_MSIX(isp) \
- (IS_24XX(isp)? (isp->isp_fwattr & ISP2400_FW_ATTR_MSIX) : 0)
+ (IS_26XX(isp)? (isp->isp_fwattr & ISP2400_FW_ATTR_MSIX) : 0)
#define ISP_CAP_VP0(isp) \
(IS_24XX(isp)? (isp->isp_fwattr & ISP2400_FW_ATTR_VP0) : 0)
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233654

Alexander Motin <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|New |In Progress
Assignee|***@FreeBSD.org |***@FreeBSD.org

--- Comment #4 from Alexander Motin <***@FreeBSD.org> ---
In r344660 I've just added tunables to control usage of MSI and MSI-X
interrupts. I am not sure yet about changing default, since I have seen not so
many complains.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de