[Bug 232466] nvme is not shut properly for suspend/resume

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232466

Conrad Meyer <***@freebsd.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org,
| |***@FreeBSD.org
Assignee|***@FreeBSD.org |***@FreeBSD.org
Severity|Affects Some People |Affects Many People
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232466

--- Comment #1 from Ben Widawsky <***@FreeBSD.org> ---
Created attachment 198507
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=198507&action=edit
Test patch for freezing devq

I don't think this is the right fix (according to Warner), but it looks like it
should be needed in addition to the correct fix.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232466

Warner Losh <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org

--- Comment #2 from Warner Losh <***@FreeBSD.org> ---
The devq freezing is racy.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232466

--- Comment #3 from Ben Widawsky <***@FreeBSD.org> ---
Could you explain how for my edification (not arguing, I just don't see it).
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232466

Scott Long <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org

--- Comment #4 from Scott Long <***@FreeBSD.org> ---
Calling cam_freeze_devq() doesn't guarantee that nothing is in-flight when it
returns. A lesser problem is that it (and xpt_freeze_simq()) also doesn't
prevent sending CCBs to the sim that aren't flagged with XPT_FC_QUEUED.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232466

Ivan <***@abinet.ru> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@abinet.ru

--- Comment #5 from Ivan <***@abinet.ru> ---
Is this (racy) fix better than no fix at all?
I have this messages on resume, but after 10 secs of freeze, the system resumes
normal operation. It's OK for me as log as it doesn't damage ZFS.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232466

Warner Losh <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|New |Closed
Resolution|--- |FIXED

--- Comment #6 from Warner Losh <***@FreeBSD.org> ---
This has been fixed in two ways. First, we properly shutdown the controller for
suspend / resume. This ensures that all I/O is drained. Second, before we get
to the shutdown, the system now syncs all mounted filesystems ensuring a stable
point.