[Bug 225666] WDC WDS120G2G0A-00JH30 SSD need quirks=0x3<4K,NCQ_TRIM_BROKEN>

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

Oleksandr Tymoshenko <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org

--- Comment #1 from Oleksandr Tymoshenko <***@FreeBSD.org> ---
Do you still have hardware to verify the fix?
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

Oleksandr Tymoshenko <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #201227|text/x-diff |text/plain
mime type| |
Attachment #201227|0 |1
is patch| |

--- Comment #2 from Oleksandr Tymoshenko <***@FreeBSD.org> ---
Created attachment 201227
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201227&action=edit
wd-green-ssd-quirk.diff

Patch with the quirk for WD Green SSD
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

Mario Olofo <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #3 from Mario Olofo <***@gmail.com> ---
Hi,
I have a WD Green SSD, model WDC WDS480G2G0B-00EPW0 with firmware UK450000 and
the quirk did not work on FreeBSD 12.0, tried to put it on loader.conf and
device.hints and it's not recognized at all, so I recompiled the kernel with
this patch but I continue to receive silent data corruptions.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

--- Comment #4 from commit-***@freebsd.org ---
A commit references this bug:

Author: scottl
Date: Thu Feb 27 05:00:21 UTC 2020
New revision: 358366
URL: https://svnweb.freebsd.org/changeset/base/358366

Log:
Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this
avoids silent data corruption.

PR: 225666
Submitted by: anders lundgren
MFC after: 3 days

Changes:
head/sys/cam/ata/ata_da.c
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

--- Comment #5 from Scott Long <***@FreeBSD.org> ---
I've committed this patch to HEAD, will merge it to 12.x and 11.x in a few
days. That will eliminate the need for a manual quirk entry. Can you say more
about what you tried and what kind of corruption resulted?
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

--- Comment #6 from Mario Olofo <***@gmail.com> ---
Yes, I had this data corruption a while ago, so I tried to get help on the
forums, but no luck. The link is
https://forums.freebsd.org/threads/fixing-metadata-errors-after-zfs-clear-zfs-scrub.72139/

So some days ago I again got time to try installing FreeBSD again so I send an
email to freebsd-stable lists, but besides the very good support from the
people, didn't found a solution so far, but tested some things:

1- Installed FBSD on a hybrid HDD, worked without errors;
2- Did a memory test from Windows and the dell diagnostics tool, no errors
found;
3- Installed on the SSD and after install, reboot and download some tools (npm,
node, git), the zpool scrub already show me checksum errors.
4- Reinstalled and this time just applied the patch and build the kernel. Did a
reboot, the quirks detected was 0x03 (from 0x0D that it detected previously),
so I downloaded the same tools, did a git clone of one of my projects, npm
install to get a lot of little files on node_modules and then after this I ran
the zpool scrub. The scrub found data errors. I think that enabling the bit 4k
just delays the problem, at least in my case.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

--- Comment #7 from Mario Olofo <***@gmail.com> ---
Tried to reinstall FreeBSD again with vfs.zfs.trim.enabled=0 and it appears
that the silent data corruptions are gone. I'll rebuild the kernel and install
more packages to use more disk space and see if the problem shows up.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

Scott Long <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org

--- Comment #8 from Scott Long <***@FreeBSD.org> ---
Thanks for your feedback. It sounds like TRIM in general is problematic for
you, not just NCQ TRIM. I'll see if I can reproduce.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

--- Comment #9 from Mario Olofo <***@gmail.com> ---
Ok, thank you.
If you need help with anything, let me know.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

--- Comment #10 from commit-***@freebsd.org ---
A commit references this bug:

Author: scottl
Date: Sun Mar 1 18:02:00 UTC 2020
New revision: 358489
URL: https://svnweb.freebsd.org/changeset/base/358489

Log:
Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this
avoids silent data corruption.

PR: 225666
Submitted by: anders lundgren

Changes:
_U stable/12/
stable/12/sys/cam/ata/ata_da.c
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

--- Comment #11 from commit-***@freebsd.org ---
A commit references this bug:

Author: scottl
Date: Sun Mar 1 18:03:09 UTC 2020
New revision: 358490
URL: https://svnweb.freebsd.org/changeset/base/358490

Log:
Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this
avoids silent data corruption.

PR: 225666
Submitted by: anders lundgren

Changes:
_U stable/11/
stable/11/sys/cam/ata/ata_da.c
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-***@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-scsi
To unsubscribe, send any mail to "freebsd-scsi-***@freebsd.org"

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225666

Mark Linimon <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|New |Closed
Resolution|--- |FIXED
Assignee|***@FreeBSD.org |***@FreeBSD.org

--- Comment #14 from Mark Linimon <***@FreeBSD.org> ---
^Triage: assign to committer who resolved.